feat(cli): support CloudFormation simplified resource import #28066

tmokmss · 2023-11-19T15:00:53Z

This PR adds a CLI option --import-exsting-resources: boolean to cdk deploy command and pass it to createChangeSet API call.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

maybe revert later

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

tmokmss · 2023-11-19T15:11:27Z

Exemption Request: I added a CLI integ test instead of framework-integ, because this is a change of CLI.

aws-cdk-automation · 2023-12-11T00:09:27Z

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

tmokmss · 2023-12-11T01:19:54Z

@vinayak-kukreja Hi, by any chance, can you run a CLI integ test pipeline and add an integ exempt label to keep this PR open?

packages/aws-cdk/lib/cli.ts

aws-cdk-automation · 2023-12-14T02:19:32Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 3cc542d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

msambol · 2023-12-14T02:20:35Z

packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts

+  await expect(fixture.aws.cloudFormation('describeStacks', {
+    StackName: fixture.fullStackName(stackName),
+  })).rejects.toThrow('does not exist');
+}));


thanks for adding this 👍🏼

msambol · 2023-12-14T02:21:31Z

LGTM 👍🏼 Thanks for adding this!

msambol

LGTM. Thanks 👍🏼

aws-cdk-automation · 2023-12-15T00:07:19Z

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/28066/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

aws-cdk-automation · 2023-12-18T00:09:51Z

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

aws-cdk-automation · 2023-12-18T00:11:30Z

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/28066/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

mergify · 2023-12-18T09:29:43Z

⚠️ The sha of the head commit of this PR conflicts with #28401. Mergify cannot evaluate rules on this PR. ⚠️

mergify · 2024-01-06T01:05:41Z

⚠️ The sha of the head commit of this PR conflicts with #28401. Mergify cannot evaluate rules on this PR. ⚠️

tmokmss added 2 commits November 19, 2023 23:58

feat(cli): support ImportExstingResources

0f8965f

update aws-sdk, but I'm not sure if it's allowed

e42494e

maybe revert later

github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK feature-request A feature should be added or improved. p2 labels Nov 19, 2023

aws-cdk-automation requested a review from a team November 19, 2023 15:01

tmokmss had a problem deploying to test-pipeline November 19, 2023 15:01 — with GitHub Actions Failure

aws-cdk-automation requested changes Nov 19, 2023

View reviewed changes

aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Nov 19, 2023

Update cli.integtest.ts

ca9cd25

tmokmss had a problem deploying to test-pipeline November 19, 2023 15:10 — with GitHub Actions Failure

aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 19, 2023

tmokmss added 2 commits November 20, 2023 09:32

fix integ

e803106

also update aws-sdk

a2fa8b4

tmokmss had a problem deploying to test-pipeline November 20, 2023 00:34 — with GitHub Actions Failure

Update deployments.ts

d66b937

tmokmss had a problem deploying to test-pipeline November 20, 2023 05:04 — with GitHub Actions Failure

tmokmss added 2 commits November 20, 2023 14:19

possible refactor to remove dead code

7e04e54

revert refactor; might do this in another PR

30c1e50

tmokmss had a problem deploying to test-pipeline November 20, 2023 05:22 — with GitHub Actions Failure

Merge branch 'main' into allow_import_resources

86f6ebc

tmokmss had a problem deploying to test-pipeline November 20, 2023 13:17 — with GitHub Actions Failure

github-actions bot mentioned this pull request Dec 1, 2023

Monthly PR metrics report - November 2023 #28212

Closed

tmokmss mentioned this pull request Dec 4, 2023

chore: npm-check-updates && yarn upgrade #28159

Closed

tmokmss added 2 commits December 7, 2023 09:59

Merge branch 'main' into allow_import_resources

9229d92

Update yarn.lock

3a2a739

tmokmss had a problem deploying to test-pipeline December 7, 2023 01:00 — with GitHub Actions Failure

github-actions bot added the effort/medium Medium work item – several days of effort label Dec 7, 2023

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 7, 2023

Update README.md

2a6aae5

tmokmss had a problem deploying to test-pipeline December 13, 2023 01:59 — with GitHub Actions Failure

Update cli.integtest.ts

07fa306

tmokmss had a problem deploying to test-pipeline December 13, 2023 02:16 — with GitHub Actions Failure

Update README.md

526daed

tmokmss had a problem deploying to test-pipeline December 13, 2023 02:20 — with GitHub Actions Failure

tmokmss added 2 commits December 13, 2023 12:00

Update deploy-stack.test.ts

d5f41e6

Update deploy-stack.test.ts

2abaeba

tmokmss had a problem deploying to test-pipeline December 13, 2023 03:01 — with GitHub Actions Failure

tmokmss had a problem deploying to test-pipeline December 13, 2023 03:02 — with GitHub Actions Failure

msambol reviewed Dec 13, 2023

View reviewed changes

packages/aws-cdk/lib/cli.ts Show resolved Hide resolved

reject only when method=direct && importExistingResources==true

3cc542d

tmokmss had a problem deploying to test-pipeline December 14, 2023 01:53 — with GitHub Actions Failure

msambol reviewed Dec 14, 2023

View reviewed changes

msambol approved these changes Dec 15, 2023

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Dec 15, 2023

aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Dec 18, 2023

aws-cdk-automation closed this Dec 18, 2023

tmokmss mentioned this pull request Dec 18, 2023

feat(cli): support CloudFormation simplified resource import #28401

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli): support CloudFormation simplified resource import #28066

feat(cli): support CloudFormation simplified resource import #28066

tmokmss commented Nov 19, 2023 •

edited

Loading

aws-cdk-automation left a comment

tmokmss commented Nov 19, 2023 •

edited

Loading

aws-cdk-automation commented Dec 11, 2023

tmokmss commented Dec 11, 2023

aws-cdk-automation commented Dec 14, 2023

msambol Dec 14, 2023

msambol commented Dec 14, 2023

msambol left a comment

aws-cdk-automation commented Dec 15, 2023

aws-cdk-automation commented Dec 18, 2023

aws-cdk-automation commented Dec 18, 2023

mergify bot commented Dec 18, 2023

mergify bot commented Jan 6, 2024

feat(cli): support CloudFormation simplified resource import #28066

feat(cli): support CloudFormation simplified resource import #28066

Conversation

tmokmss commented Nov 19, 2023 • edited Loading

aws-cdk-automation left a comment

Choose a reason for hiding this comment

tmokmss commented Nov 19, 2023 • edited Loading

aws-cdk-automation commented Dec 11, 2023

tmokmss commented Dec 11, 2023

aws-cdk-automation commented Dec 14, 2023

AWS CodeBuild CI Report

msambol Dec 14, 2023

Choose a reason for hiding this comment

msambol commented Dec 14, 2023

msambol left a comment

Choose a reason for hiding this comment

aws-cdk-automation commented Dec 15, 2023

aws-cdk-automation commented Dec 18, 2023

aws-cdk-automation commented Dec 18, 2023

mergify bot commented Dec 18, 2023

mergify bot commented Jan 6, 2024

tmokmss commented Nov 19, 2023 •

edited

Loading

tmokmss commented Nov 19, 2023 •

edited

Loading